android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2024-12-21 07:16:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mention exceptions to Google Style Guide in SUBMITTING_PATCHES.md

Browse Source 
Change-Id: I05d313c66f312942405a884a54118cb1d7af1bac
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254671
Tested-by: David Pursehouse <dpursehouse@collab.net>
Reviewed-by: Mike Frysinger <vapier@google.com>
This commit is contained in:
David Pursehouse 2020-02-13 10:34:05 +09:00
parent 3c5114cd78
commit daa2cecdc5
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
SUBMITTING_PATCHES.md
View File

@ -55,9 +55,14 @@ Run `flake8` on changes modules:
flake8 file.py
Note that repo generally follows [Google's python style guide] rather than
[PEP 8], so it's possible that the output of `flake8` will be quite noisy.
It's not mandatory to avoid all warnings, but at least the maximum line
length should be followed.
[PEP 8], with a couple of notable exceptions:
* Indentation is at 2 columns rather than 4
* The maximum line length is 100 columns rather than 80
It's possible that the output of `flake8` will be quite noisy, so it's not
mandatory to avoid all warnings, but at least the maximum line length
should be followed.
If there are many occurrences of the same warning that cannot be
avoided without going against the Google style guide, these may be