From daa2cecdc5b8dad4361f9dd0c9acf4dd7a508729 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Thu, 13 Feb 2020 10:34:05 +0900 Subject: [PATCH] Mention exceptions to Google Style Guide in SUBMITTING_PATCHES.md Change-Id: I05d313c66f312942405a884a54118cb1d7af1bac Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254671 Tested-by: David Pursehouse Reviewed-by: Mike Frysinger --- SUBMITTING_PATCHES.md | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/SUBMITTING_PATCHES.md b/SUBMITTING_PATCHES.md index 5021e7ee..316cb620 100644 --- a/SUBMITTING_PATCHES.md +++ b/SUBMITTING_PATCHES.md @@ -55,9 +55,14 @@ Run `flake8` on changes modules: flake8 file.py Note that repo generally follows [Google's python style guide] rather than -[PEP 8], so it's possible that the output of `flake8` will be quite noisy. -It's not mandatory to avoid all warnings, but at least the maximum line -length should be followed. +[PEP 8], with a couple of notable exceptions: + +* Indentation is at 2 columns rather than 4 +* The maximum line length is 100 columns rather than 80 + +It's possible that the output of `flake8` will be quite noisy, so it's not +mandatory to avoid all warnings, but at least the maximum line length +should be followed. If there are many occurrences of the same warning that cannot be avoided without going against the Google style guide, these may be