mirror of
https://gerrit.googlesource.com/git-repo
synced 2024-12-21 07:16:21 +00:00
d9254599f9
We also need to check more things in the manifest/project handlers, and use platform_utils in a few places to address Windows behavior. Drop Python 2.7 from Windows testing as it definitely doesn't work and we won't be fixing it. Change-Id: I83d00ee9f1612312bb3f7147cb9535fc61268245 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/256113 Tested-by: Mike Frysinger <vapier@google.com> Reviewed-by: Jonathan Nieder <jrn@google.com> Reviewed-by: David Pursehouse <dpursehouse@collab.net>
92 lines
2.7 KiB
Python
92 lines
2.7 KiB
Python
# -*- coding:utf-8 -*-
|
|
#
|
|
# Copyright (C) 2019 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Unittests for the manifest_xml.py module."""
|
|
|
|
from __future__ import print_function
|
|
|
|
import os
|
|
import unittest
|
|
|
|
import error
|
|
import manifest_xml
|
|
|
|
|
|
class ManifestValidateFilePaths(unittest.TestCase):
|
|
"""Check _ValidateFilePaths helper.
|
|
|
|
This doesn't access a real filesystem.
|
|
"""
|
|
|
|
def check_both(self, *args):
|
|
manifest_xml.XmlManifest._ValidateFilePaths('copyfile', *args)
|
|
manifest_xml.XmlManifest._ValidateFilePaths('linkfile', *args)
|
|
|
|
def test_normal_path(self):
|
|
"""Make sure good paths are accepted."""
|
|
self.check_both('foo', 'bar')
|
|
self.check_both('foo/bar', 'bar')
|
|
self.check_both('foo', 'bar/bar')
|
|
self.check_both('foo/bar', 'bar/bar')
|
|
|
|
def test_symlink_targets(self):
|
|
"""Some extra checks for symlinks."""
|
|
def check(*args):
|
|
manifest_xml.XmlManifest._ValidateFilePaths('linkfile', *args)
|
|
|
|
# We allow symlinks to end in a slash since we allow them to point to dirs
|
|
# in general. Technically the slash isn't necessary.
|
|
check('foo/', 'bar')
|
|
# We allow a single '.' to get a reference to the project itself.
|
|
check('.', 'bar')
|
|
|
|
def test_bad_paths(self):
|
|
"""Make sure bad paths (src & dest) are rejected."""
|
|
PATHS = (
|
|
'..',
|
|
'../',
|
|
'./',
|
|
'foo/',
|
|
'./foo',
|
|
'../foo',
|
|
'foo/./bar',
|
|
'foo/../../bar',
|
|
'/foo',
|
|
'./../foo',
|
|
'.git/foo',
|
|
# Check case folding.
|
|
'.GIT/foo',
|
|
'blah/.git/foo',
|
|
'.repo/foo',
|
|
'.repoconfig',
|
|
# Block ~ due to 8.3 filenames on Windows filesystems.
|
|
'~',
|
|
'foo~',
|
|
'blah/foo~',
|
|
# Block Unicode characters that get normalized out by filesystems.
|
|
u'foo\u200Cbar',
|
|
)
|
|
# Make sure platforms that use path separators (e.g. Windows) are also
|
|
# rejected properly.
|
|
if os.path.sep != '/':
|
|
PATHS += tuple(x.replace('/', os.path.sep) for x in PATHS)
|
|
|
|
for path in PATHS:
|
|
self.assertRaises(
|
|
error.ManifestInvalidPathError, self.check_both, path, 'a')
|
|
self.assertRaises(
|
|
error.ManifestInvalidPathError, self.check_both, 'a', path)
|