mirror of
https://gerrit.googlesource.com/git-repo
synced 2024-12-21 07:16:21 +00:00
bb930461ce
The current subcmds design has singletons in all_commands. This isn't exactly unusual, but the fact that our main & help subcommand will then attach members to the classes before invoking them is. This makes it hard to keep track of what members a command has access to, and the two code paths (main & help) attach different members depending on what APIs they then invoke. Lets pull this back a step by storing classes in all_commands and leave the instantiation step to when they're used. This doesn't fully clean up the confusion, but gets us closer. Change-Id: I6a768ff97fe541e6f3228358dba04ed66c4b070a Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/259154 Tested-by: Mike Frysinger <vapier@google.com> Reviewed-by: David Pursehouse <dpursehouse@collab.net>
52 lines
1.5 KiB
Python
52 lines
1.5 KiB
Python
# -*- coding:utf-8 -*-
|
|
#
|
|
# Copyright (C) 2008 The Android Open Source Project
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import os
|
|
|
|
# A mapping of the subcommand name to the class that implements it.
|
|
all_commands = {}
|
|
|
|
my_dir = os.path.dirname(__file__)
|
|
for py in os.listdir(my_dir):
|
|
if py == '__init__.py':
|
|
continue
|
|
|
|
if py.endswith('.py'):
|
|
name = py[:-3]
|
|
|
|
clsn = name.capitalize()
|
|
while clsn.find('_') > 0:
|
|
h = clsn.index('_')
|
|
clsn = clsn[0:h] + clsn[h + 1:].capitalize()
|
|
|
|
mod = __import__(__name__,
|
|
globals(),
|
|
locals(),
|
|
['%s' % name])
|
|
mod = getattr(mod, name)
|
|
try:
|
|
cmd = getattr(mod, clsn)
|
|
except AttributeError:
|
|
raise SyntaxError('%s/%s does not define class %s' % (
|
|
__name__, py, clsn))
|
|
|
|
name = name.replace('_', '-')
|
|
cmd.NAME = name
|
|
all_commands[name] = cmd
|
|
|
|
# Add 'branch' as an alias for 'branches'.
|
|
all_commands['branch'] = all_commands['branches']
|