git-repo/subcmds
Mike Frysinger 19e409c818 ssh: move proxy usage to the sync subcommand
The only time we really need ssh proxies is when we want to run many
connections and reuse them.  That only happens when running sync.
Every other command makes at most two connections, and even then it's
only one or none.  So the effort of setting up & tearing down ssh
proxies isn't worth it most of the time.

The big reason we want to move this logic to sync is that it's now
using multiprocessing for parallel work.  The current ssh proxy code
is all based on threads, which means none of the logic is working
correctly.  The current ssh design makes it hard to fix when all of
the state lives in the global/module scope.

So the first step to fixing this is top move the setup & teardown to
the one place that really needs it: sync.  No other commands will use
proxies anymore, just direct connections.

Bug: https://crbug.com/gerrit/12389
Change-Id: Ibd351acdec39a87562b3013637c5df4ea34e03c6
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/305485
Reviewed-by: Chris Mcdonald <cjmcdonald@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2021-05-10 21:10:29 +00:00
..
__init__.py strip python2-only coding:utf-8 & print_function settings 2021-01-06 18:53:05 +00:00
abandon.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
branches.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
checkout.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
cherry_pick.py command: make --verbose/--quiet available to all subcommands 2021-04-13 22:25:17 +00:00
diff.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
diffmanifests.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
download.py download: handle shared projects a bit better 2021-03-01 15:57:17 +00:00
forall.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
gitc_delete.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
gitc_init.py init: merge subcmd & wrapper parsers 2021-04-09 01:04:32 +00:00
grep.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
help.py help/version: sprinkle bug report URL around 2021-04-26 21:43:43 +00:00
info.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
init.py command: make --verbose/--quiet available to all subcommands 2021-04-13 22:25:17 +00:00
list.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
manifest.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
overview.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
prune.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
rebase.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
selfupdate.py strip python2-only coding:utf-8 & print_function settings 2021-01-06 18:53:05 +00:00
smartsync.py strip python2-only coding:utf-8 & print_function settings 2021-01-06 18:53:05 +00:00
stage.py command: make --verbose/--quiet available to all subcommands 2021-04-13 22:25:17 +00:00
start.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
status.py command: add a helper for the parallel execution boilerplate 2021-04-15 05:10:16 +00:00
sync.py ssh: move proxy usage to the sync subcommand 2021-05-10 21:10:29 +00:00
upload.py subcmds: force consistent help text format 2021-05-04 16:40:53 +00:00
version.py help/version: sprinkle bug report URL around 2021-04-26 21:43:43 +00:00