ea2e330e43
Format codebase with black and check formatting in CQ
...
Apply rules set by https://gerrit-review.googlesource.com/c/git-repo/+/362954/ across the codebase and fix any lingering errors caught
by flake8. Also check black formatting in run_tests (and CQ).
Bug: b/267675342
Change-Id: I972d77649dac351150dcfeb1cd1ad0ea2efc1956
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/363474
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2023-03-22 17:46:28 +00:00
0324e43242
repo_trace: Avoid race conditions with trace_file updating.
...
Change-Id: I0bc1bb3c8f60465dc6bee5081688a9f163dd8cf8
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/354515
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: Joanna Wang <jojwang@google.com >
2022-12-09 22:49:31 +00:00
ed25be569e
repo_trace: drop notification of trace file name.
...
The trace file is local to the workspace. We shouldn't tell the user
that on every command that they run.
Change-Id: I8674ab485bd5142814a043a225bf8aaca7795752
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/351234
Tested-by: LaMont Jones <lamontjones@google.com >
Reviewed-by: Xin Li <delphij@google.com >
2022-11-14 23:46:06 +00:00
afd767103e
repo_trace: adjust formatting, update man page.
...
No behavior change in this CL.
Change-Id: Iab1eb01864ea8a5aec3a683200764d20786b42de
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/351474
Tested-by: LaMont Jones <lamontjones@google.com >
Reviewed-by: Xin Li <delphij@google.com >
2022-11-14 23:46:06 +00:00
47020ba249
trace: restore Progress indicator.
...
If we are not tracing to stderr, then we should still have progress
indication.
Change-Id: Ifc9678e1fccbd92251e972fcf25aad6369d60e15
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/351195
Reviewed-by: Sam Saccone <samccone@google.com >
Tested-by: LaMont Jones <lamontjones@google.com >
Reviewed-by: Xin Li <delphij@google.com >
2022-11-10 00:44:33 +00:00
24c6314fca
Fix TRACE_FILE renaming.
...
Bug: b/258073923
Change-Id: I997961056388e1550711f73a6310788b5c7ad4d4
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/350934
Tested-by: Joanna Wang <jojwang@google.com >
Reviewed-by: LaMont Jones <lamontjones@google.com >
2022-11-09 01:24:49 +00:00
a3ff64cae5
Improve always-on-trace
...
Notes to the user need to go to stderr, and tracing should not be on for
fast exiting invocations (such as --help).
This makes it so that release/update-manpages works.
Change-Id: Ib183193c868a78c295a184c01c4532cd53d512eb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/350794
Tested-by: LaMont Jones <lamontjones@google.com >
Reviewed-by: Xin Li <delphij@google.com >
2022-11-08 19:54:20 +00:00
a6c52f566a
Set tracing to always on and save to .repo/TRACE_FILE.
...
- add `--trace_to_stderr` option so stderr will include trace outputs and any other errors that get sent to stderr
- while TRACE_FILE will only include trace outputs
piggy-backing on: https://gerrit-review.googlesource.com/c/git-repo/+/349154
Change-Id: I3895a84de4b2784f17fac4325521cd5e72e645e2
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/350114
Reviewed-by: LaMont Jones <lamontjones@google.com >
Tested-by: Joanna Wang <jojwang@google.com >
2022-11-03 21:07:07 +00:00
784ccfc040
strip python2-only coding:utf-8 & print_function settings
...
We're committed to Python 3 at this point, so clean up boilerplate.
Bug: https://crbug.com/gerrit/10418
Change-Id: Ib1719ba2eb65c53b94881a1a1bf203ddfcaaafed
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292382
Reviewed-by: Chris Mcdonald <cjmcdonald@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2021-01-06 18:53:05 +00:00
819827a42d
Fix blank line issues reported by flake8
...
- E301 expected 1 blank line
- E302 expected 2 blank lines
- E303 too many blank lines
- E305 expected 2 blank lines after class or function definition
- E306 expected 1 blank line before a nested definition
Fixed automatically with autopep8:
git ls-files | grep py$ | xargs autopep8 --in-place \
--select E301,E302,E303,E305,E306
Manually fix issues in project.py caused by misuse of block comments.
Change-Id: Iee840fcaff48aae504ddac9c3e76d2acd484f6a9
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254599
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: David Pursehouse <dpursehouse@collab.net >
2020-02-12 06:36:40 +00:00
8a11f6f24c
rename local trace module
...
There is a standard Python "trace" module, so having a local trace.py
prevents us being able to import that. Rename the module to avoid.
Change-Id: I23e29ec95a2204bb168a641323d05e76968d9b57
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/234832
Reviewed-by: David Pursehouse <dpursehouse@collab.net >
Tested-by: Mike Frysinger <vapier@google.com >
2019-08-27 07:08:52 +00:00
