b32ccbb66b
cleanup: Update codebase to expect Python 3.6
...
- Bump minimum version to Python 3.6.
- Use f-strings in a lot of places.
Change-Id: I2aa70197230fcec2eff8e7c8eb754f20c08075bb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/389034
Tested-by: Jason R. Coombs <jaraco@google.com >
Reviewed-by: Mike Frysinger <vapier@google.com >
Commit-Queue: Jason R. Coombs <jaraco@google.com >
2023-10-31 16:03:54 +00:00
6447733eb2
isort: format codebase
...
Change-Id: I6f11d123b68fd077f558d3c21349c55c5f251019
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/383715
Reviewed-by: Gavin Mak <gavinmak@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
Commit-Queue: Mike Frysinger <vapier@google.com >
2023-08-22 18:32:22 +00:00
ea2e330e43
Format codebase with black and check formatting in CQ
...
Apply rules set by https://gerrit-review.googlesource.com/c/git-repo/+/362954/ across the codebase and fix any lingering errors caught
by flake8. Also check black formatting in run_tests (and CQ).
Bug: b/267675342
Change-Id: I972d77649dac351150dcfeb1cd1ad0ea2efc1956
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/363474
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2023-03-22 17:46:28 +00:00
acf63b2892
drop pyversion & is_python3 checking
...
We're committed to Python 3 at this point, so purge all the
is_python3 related dynamic checks.
Bug: https://crbug.com/gerrit/10418
Change-Id: I4c8b405d6de359b8b83223c9f4b9c8ffa18ea1a2
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292383
Reviewed-by: Chris Mcdonald <cjmcdonald@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2021-01-06 18:53:58 +00:00
784ccfc040
strip python2-only coding:utf-8 & print_function settings
...
We're committed to Python 3 at this point, so clean up boilerplate.
Bug: https://crbug.com/gerrit/10418
Change-Id: Ib1719ba2eb65c53b94881a1a1bf203ddfcaaafed
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/292382
Reviewed-by: Chris Mcdonald <cjmcdonald@google.com >
Tested-by: Mike Frysinger <vapier@google.com >
2021-01-06 18:53:05 +00:00
a46bf7dc2a
flake8: Suppress "F821 undefined name" inline for Python 2 names
...
All of the instances of this are related to Python 2 names that
don't exist in Python 3, and the warnings are raised when running
flake8 on Python 3.
All of these will go away once we completely remove support for
Python 2, so just suppress them inline. We don't globally suppress
the check so that we will still see legitimate errors if/when they
occur in new code.
Change-Id: Iccf955f50abfc9f83b371fc0af6cceb51037456f
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255039
Tested-by: David Pursehouse <dpursehouse@collab.net >
Reviewed-by: Mike Frysinger <vapier@google.com >
2020-02-15 04:45:16 +00:00
3cda50a41b
pyflakes: Fix remaining "E501 line too long" warnings
...
We increased the max line length to 100 columns which got rid of
the majority of these warnings, but there were still a few lines
that exceeded 100 columns.
Change-Id: Ib3372868ca2297f83073a14f91c8ae3df9d0d0e6
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254699
Tested-by: David Pursehouse <dpursehouse@collab.net >
Reviewed-by: Mike Frysinger <vapier@google.com >
2020-02-13 04:54:10 +00:00
dbd277ce50
[Win32] Make platform_utils compatible for Python3
...
On Python 3 several imports are to be imported from
different locations.
Signed-off-by: Remy Böhmer <linux@bohmer.net >
Change-Id: I4f243d145f65e38f74743a742583cfc5c5d76deb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/249610
Reviewed-by: Mike Frysinger <vapier@google.com >
2020-02-06 14:29:15 +00:00
9da67feecf
Fix a typo
...
Change-Id: I1d1d1c7ec6c0c706eb08ceb803c37e1ce1baf8b3
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/251834
Reviewed-by: David Pursehouse <dpursehouse@collab.net >
Tested-by: Rostislav Krasny <rostigm@gmail.com >
2020-01-25 00:53:39 +00:00
b71d61d34e
Make _preserve_encoding in platform_utils_win32 compatible with Python 3
...
Bug: https://crbug.com/gerrit/12145
Change-Id: I01d1ef96ff7b474f55ed42ecc13bd5943006d3b5
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/251833
Reviewed-by: Mike Frysinger <vapier@google.com >
Tested-by: Rostislav Krasny <rostigm@gmail.com >
2020-01-24 21:50:22 +00:00
f601376e13
set default file encoding to utf-8
...
There's no reason to support any other encoding in these files.
This only affects the files themselves and not streams they open.
Bug: https://crbug.com/gerrit/10418
Change-Id: I053cb40cd3666ce5c8a0689b9dd938f24ca765bf
2019-06-13 14:30:52 +00:00
a84df06160
platform_utils_win32: remove an unnecessary workaround
...
The comment in _create_symlink is incorrect. The return value of
CreateSymbolicLink is as documented, it was just declared with
the wrong return type. The actual return type is BOOLEAN, not BOOL.
Fixing this allows us to simplify the code a bit.
Change-Id: I4d2190a50d45ba41dd9814bf7079a5784fc0a366
2019-03-21 23:45:59 +03:00
2b42d288c0
Windows: Add support for creating symlinks as an unprivileged user
...
See https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/
for announcement of new flag.
This change follow the same pattern as what was done in "go":
https://github.com/golang/go/pull/24307/files#diff-b87bc12e4da2497308f9ef746086e4f0
Change-Id: If1e99fefdd3f787598e695731019c34b9bfcd1c2
2018-10-03 09:41:09 -07:00
227ad2ef42
Implement islink, readlink and realpath using Win32 api
...
Change-Id: I18452cbb32d24db73601ad10485dbe6bb278731c
2017-08-31 13:49:01 -07:00
d5cec5e752
Add support for creating symbolic links on Windows
...
Replace all calls to os.symlink with platform_utils.symlink.
The Windows implementation calls into the CreateSymbolicLinkW Win32
API, as os.symlink is not supported.
Separate the Win32 API definitions into a separate module
platform_utils_win32 for clarity.
Change-Id: I0714c598664c2df93383734e609d948692c17ec5
2017-05-29 19:30:34 +09:00
