From fc241240d828d7e8302dc0876608a9d27ae1cbc7 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 14 Nov 2012 09:19:39 +0900 Subject: [PATCH] Convert prompt answers to lower case before checking When prompting for yes/no answers, convert the answer to lower case before comparing. This makes it easier to catch answers like "Yes", "yes", and "YES" with a comparison only for "yes". Change-Id: I06da8281cec81a7438ebb46ddaf3344d12abe1eb --- subcmds/init.py | 2 +- subcmds/upload.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/subcmds/init.py b/subcmds/init.py index 48df9e89..99007d60 100644 --- a/subcmds/init.py +++ b/subcmds/init.py @@ -248,7 +248,7 @@ to update the working directory files. print '' print 'Your identity is: %s <%s>' % (name, email) sys.stdout.write('is this correct [y/N]? ') - a = sys.stdin.readline().strip() + a = sys.stdin.readline().strip().lower() if a in ('yes', 'y', 't', 'true'): break diff --git a/subcmds/upload.py b/subcmds/upload.py index 39721ac2..925652c2 100644 --- a/subcmds/upload.py +++ b/subcmds/upload.py @@ -186,8 +186,8 @@ Gerrit Code Review: http://code.google.com/p/gerrit/ print ' %s' % commit sys.stdout.write('to %s (y/N)? ' % remote.review) - answer = sys.stdin.readline().strip() - answer = answer in ('y', 'Y', 'yes', '1', 'true', 't') + answer = sys.stdin.readline().strip().lower() + answer = answer in ('y', 'yes', '1', 'true', 't') if answer: if len(branch.commits) > UNUSUAL_COMMIT_THRESHOLD: