android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2024-12-21 07:16:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reword the documentation regarding coding style

Browse Source 
- flake8 is a wrapper around pyflakes, so it's redundant to mention
  both of them. Roll the explicit sections about coding errors and
  coding style violations into a single section.

- After recent cleanups the project now has zero warnings or errors
  from flake8. Reword the requirements so that it is now mandatory
  to not introduce new warnings.

- Expand the section on suppression of warnings to differentiate
  between suppressing inline individually and globally suppressing
  for the whole project.

- Properly capitalize "Python Style Guide".

Change-Id: I4b333d013e985db252873441b16cb719ed5be5b5
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/255040
Tested-by: David Pursehouse <dpursehouse@collab.net>
Reviewed-by: Mike Frysinger <vapier@google.com>
This commit is contained in:
David Pursehouse 2020-02-15 13:51:17 +09:00 committed by Mike Frysinger
parent 6a784ff9a6
commit d6b8bd464c
1 changed files with 13 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
SUBMITTING_PATCHES.md
View File

@ -4,7 +4,7 @@
- Make small logical changes. - Make small logical changes.
- Provide a meaningful commit message. - Provide a meaningful commit message.
- Check for coding errors and style nits with pyflakes and flake8 - Check for coding errors and style nits with flake8.
- Make sure all code is under the Apache License, 2.0. - Make sure all code is under the Apache License, 2.0.
- Publish your changes for review. - Publish your changes for review.
- Make corrections if requested. - Make corrections if requested.
@ -38,39 +38,30 @@ If your description starts to get too long, that's a sign that you
probably need to split up your commit to finer grained pieces. probably need to split up your commit to finer grained pieces.
## Check for coding errors and style nits with pyflakes and flake8 ## Check for coding errors and style violations with flake8
### Coding errors Run `flake8` on changed modules:
Run `pyflakes` on changed modules:
pyflakes file.py
Ideally there should be no new errors or warnings introduced.
### Style violations
Run `flake8` on changes modules:
flake8 file.py flake8 file.py
Note that repo generally follows [Google's python style guide] rather than Note that repo generally follows [Google's Python Style Guide] rather than
[PEP 8], with a couple of notable exceptions: [PEP 8], with a couple of notable exceptions:
* Indentation is at 2 columns rather than 4 * Indentation is at 2 columns rather than 4
* The maximum line length is 100 columns rather than 80 * The maximum line length is 100 columns rather than 80
It's possible that the output of `flake8` will be quite noisy, so it's not There should be no new errors or warnings introduced.
mandatory to avoid all warnings, but at least the maximum line length
should be followed.
If there are many occurrences of the same warning that cannot be Warnings that cannot be avoided without going against the Google Style Guide
avoided without going against the Google style guide, these may be may be suppressed inline individally using a `# noqa` comment as described
suppressed in the included `.flake8` file. in the [flake8 documentation].
[Google's python style guide]: https://google.github.io/styleguide/pyguide.html If there are many occurrences of the same warning, these may be suppressed for
the entire project in the included `.flake8` file.
[Google's Python Style Guide]: https://google.github.io/styleguide/pyguide.html
[PEP 8]: https://www.python.org/dev/peps/pep-0008/ [PEP 8]: https://www.python.org/dev/peps/pep-0008/
[flake8 documentation]: https://flake8.pycqa.org/en/3.1.1/user/ignoring-errors.html#in-line-ignoring-errors
## Running tests ## Running tests