android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2024-12-21 07:16:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

forall.py: Close file after removing the stream

Browse Source 
In order to remove the stream fileno() will be called on the filedescriptor.
If the file is already closed fileno() will raise an error and forall
will fail.

Bug: https://crbug.com/gerrit/12563
Change-Id: Ib7b895fe881c844e3eb3672b011fdcdbdae63024
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/262838
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Karsten Pfeiffer-Raddatz <raddatz.karsten@gmail.com>
This commit is contained in:
Karsten Pfeiffer-Raddatz 2020-04-13 13:48:04 +02:00
parent 2735bfc5ff
commit d086467012
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
subcmds/forall.py
View File

@ -370,8 +370,8 @@ def DoWork(project, mirror, opt, cmd, shell, cnt, config):
for s in in_ready: for s in in_ready:
buf = s.read().decode() buf = s.read().decode()
if not buf: if not buf:
s.close()
s_in.remove(s) s_in.remove(s)
s.close()
continue continue
if not opt.verbose: if not opt.verbose: