mirror of
https://gerrit.googlesource.com/git-repo
synced 2024-12-21 07:16:21 +00:00
sync: fix connection error on macOS
With a large number of sync workers, the sync process may fail on macOS due to connection errors. The root cause is that multiple workers may attempt to connect to the multiprocessing manager server at the same time when handling the first job. This can lead to connection failures if there are too many pending connections, exceeding the socket listening backlog. Bug: 377538810 Change-Id: I1924d318d076ca3be61d75daa37bfa8d7dc23ed7 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/441541 Tested-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
This commit is contained in:
parent
aada468916
commit
ab2d321104
@ -821,6 +821,16 @@ later is required to fix a server side protocol bug.
|
|||||||
jobs = jobs_str(len(items))
|
jobs = jobs_str(len(items))
|
||||||
return f"{jobs} | {elapsed_str(elapsed)} {earliest_proj}"
|
return f"{jobs} | {elapsed_str(elapsed)} {earliest_proj}"
|
||||||
|
|
||||||
|
@classmethod
|
||||||
|
def InitWorker(cls):
|
||||||
|
# Force connect to the manager server now.
|
||||||
|
# This is good because workers are initialized one by one. Without this,
|
||||||
|
# multiple workers may connect to the manager when handling the first
|
||||||
|
# job at the same time. Then the connection may fail if too many
|
||||||
|
# connections are pending and execeeded the socket listening backlog,
|
||||||
|
# especially on MacOS.
|
||||||
|
len(cls.get_parallel_context()["sync_dict"])
|
||||||
|
|
||||||
def _Fetch(self, projects, opt, err_event, ssh_proxy, errors):
|
def _Fetch(self, projects, opt, err_event, ssh_proxy, errors):
|
||||||
ret = True
|
ret = True
|
||||||
|
|
||||||
@ -913,6 +923,7 @@ later is required to fix a server side protocol bug.
|
|||||||
# idle while other workers still have more than one job in
|
# idle while other workers still have more than one job in
|
||||||
# their chunk queue.
|
# their chunk queue.
|
||||||
chunksize=1,
|
chunksize=1,
|
||||||
|
initializer=self.InitWorker,
|
||||||
)
|
)
|
||||||
finally:
|
finally:
|
||||||
sync_event.set()
|
sync_event.set()
|
||||||
|
Loading…
Reference in New Issue
Block a user