From 91f428058d7d23709c057850580fe0315bd74f76 Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Tue, 25 Mar 2025 12:58:26 -0400 Subject: [PATCH] run_tests: run all tests all the time Using a generator w/all() causes the code to exit on the first error. We really want to see all errors all the time, so use sum() instead. Change-Id: Ib1adb8de199db9fe727d4b49c890b4d5061e9e6b Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/462901 Tested-by: Mike Frysinger Commit-Queue: Mike Frysinger Reviewed-by: Scott Lee --- run_tests | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/run_tests b/run_tests index 3e0e5016..bb7ca915 100755 --- a/run_tests +++ b/run_tests @@ -63,7 +63,9 @@ def main(argv): run_flake8, run_isort, ) - return 0 if all(not c() for c in checks) else 1 + # Run all the tests all the time to get full feedback. Don't exit on the + # first error as that makes it more difficult to iterate in the CQ. + return 1 if sum(c() for c in checks) else 0 if __name__ == "__main__":