android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2024-12-21 07:16:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

project: rev_list: simplify execution

Browse Source 
Currently we read the binary stream from the subprocess code directly
before waiting for it to finish, but there's no need to do so as we
aren't streaming the output to the user.  This also means we pass up
binary data to the caller as we don't go through GitCommand's internal
logic which decodes the stream as utf-8.

Simplify the code by calling Wait first, then splitting the entire
captured output in one line.

Bug: https://crbug.com/gerrit/10418
Change-Id: I7a57904be8cb546a229980fb79c829fc3df31e7d
This commit is contained in:
Mike Frysinger 2019-07-04 18:13:31 -04:00
parent 1b9adab75a
commit 81f5c59671
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
project.py
View File

@ -2815,15 +2815,10 @@ class Project(object):
gitdir=self._gitdir, gitdir=self._gitdir,
capture_stdout=True, capture_stdout=True,
capture_stderr=True) capture_stderr=True)
r = []
for line in p.process.stdout:
if line[-1] == '\n':
line = line[:-1]
r.append(line)
if p.Wait() != 0: if p.Wait() != 0:
raise GitError('%s rev-list %s: %s' % raise GitError('%s rev-list %s: %s' %
(self._project.name, str(args), p.stderr)) (self._project.name, str(args), p.stderr))
return r return p.stdout.splitlines()
def __getattr__(self, name): def __getattr__(self, name):
"""Allow arbitrary git commands using pythonic syntax. """Allow arbitrary git commands using pythonic syntax.