From 6d821124e0f7fa2b6d9a5154851354cf4af70d9d Mon Sep 17 00:00:00 2001 From: Josh Bartel Date: Fri, 10 Nov 2023 15:49:42 -0600 Subject: [PATCH] repo_logging: Ensure error details are printed This updates RepoLogger.log_aggregated_errors to print out the error message the RepoExitError when there is not a list of aggregated errors. Previously it would log out: ======================================================================= Repo command failed: ManifestParseError This told us what class of error occurred but missed the helpful error message that developers put in the error. After this change it will now print out the error message: ======================================================================= Repo command failed: ManifestParseError error parsing manifest /path/to/manifest.xml: no element found: line 197, column 0 Change-Id: I4805540fddb5fa9171dbc8912becfa7fdfb1ba67 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/392614 Commit-Queue: Aravind Vasudevan Tested-by: Joshua Bartel Reviewed-by: Aravind Vasudevan --- repo_logging.py | 1 + 1 file changed, 1 insertion(+) diff --git a/repo_logging.py b/repo_logging.py index 49f0ee8b..20a53429 100644 --- a/repo_logging.py +++ b/repo_logging.py @@ -77,6 +77,7 @@ class RepoLogger(logging.Logger): if not err.aggregate_errors: self.error("Repo command failed: %s", type(err).__name__) + self.error("\t%s", str(err)) return self.error(