From 46702eddc7b5f38391e121e47f0ab4dbd6fbdf58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20M=C3=BCller-Klieser?= Date: Fri, 30 Aug 2019 10:20:15 +0200 Subject: [PATCH] sync: fix deprecated command line option -f MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In commit d9e5cf0e ("sync: invert --force-broken with --fail-fast") the force-broken option has been deprecated. Accidentally the option has been changed from Boolean to Value. This breaks all users of repo with: main.py: error: -f option requires an argument This is easy to avoid by keeping the type. Signed-off-by: Stefan Müller-Klieser Change-Id: Ia8b589cf41ac756d10c61e17ec8d76ba8f7031f9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/235043 Reviewed-by: David Pursehouse Reviewed-by: Mike Frysinger Tested-by: Mike Frysinger --- subcmds/sync.py | 1 + 1 file changed, 1 insertion(+) diff --git a/subcmds/sync.py b/subcmds/sync.py index 5655a1e6..f1fe88d8 100644 --- a/subcmds/sync.py +++ b/subcmds/sync.py @@ -199,6 +199,7 @@ later is required to fix a server side protocol bug. self.jobs = 1 p.add_option('-f', '--force-broken', + dest='force_broken', action='store_true', help='obsolete option (to be deleted in the future)') p.add_option('--fail-fast', dest='fail_fast', action='store_true',