mirror of
https://gerrit.googlesource.com/git-repo
synced 2024-12-21 07:16:21 +00:00
project: fix bytes/str encoding when updating git submodules
Since tempfile.mkstemp() returns a file handle in binary mode,
make sure we turn our strings into bytes before writing.
Bug: https://crbug.com/gerrit/12043
Change-Id: I3e84d595e84b8bc12a1fbc7fd0bb3ea0ba2832b0
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/254393
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
(cherry picked from commit 163d42eb43
)
This commit is contained in:
parent
19607b2817
commit
45d1c372a7
@ -1989,7 +1989,7 @@ class Project(object):
|
|||||||
gitmodules_lines = []
|
gitmodules_lines = []
|
||||||
fd, temp_gitmodules_path = tempfile.mkstemp()
|
fd, temp_gitmodules_path = tempfile.mkstemp()
|
||||||
try:
|
try:
|
||||||
os.write(fd, p.stdout)
|
os.write(fd, p.stdout.encode('utf-8'))
|
||||||
os.close(fd)
|
os.close(fd)
|
||||||
cmd = ['config', '--file', temp_gitmodules_path, '--list']
|
cmd = ['config', '--file', temp_gitmodules_path, '--list']
|
||||||
p = GitCommand(None, cmd, capture_stdout=True, capture_stderr=True,
|
p = GitCommand(None, cmd, capture_stdout=True, capture_stderr=True,
|
||||||
|
Loading…
Reference in New Issue
Block a user