From 337aee0a9c6714027ff4fa8659879b0710e2e6aa Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Wed, 13 Jun 2012 10:40:46 -0700 Subject: [PATCH] Single quote http.proxy in GIT_CONFIG_PARAMETERS Git requires the values in this environment variable to be single quoted. repo must wrap the expression into '' before adding it to the environment. Change-Id: I20a1fb8772f9aa6e9fd5a0516c981c2ca020ef05 --- git_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git_command.py b/git_command.py index 634058f9..9bed799e 100644 --- a/git_command.py +++ b/git_command.py @@ -148,7 +148,7 @@ class GitCommand(object): _setenv(env, 'REPO_SSH_SOCK', ssh_sock()) _setenv(env, 'GIT_SSH', _ssh_proxy()) if 'http_proxy' in env and 'darwin' == sys.platform: - s = 'http.proxy=' + env['http_proxy'] + s = "'http.proxy=%s'" % (env['http_proxy'],) p = env.get('GIT_CONFIG_PARAMETERS') if p is not None: s = p + ' ' + s