android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2025-01-02 16:14:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only display a progress meter once we spend 0.5 seconds on a task

Browse Source 
The point of the progress meter is to let the user know that the
task is progressing, and give them a chance to estimate when it will
be complete.  If the task completes in under 0.5 seconds then it
is sufficiently fast enough that the user doesn't need to be kept
up-to-date on its progress; in fact showing the meter may just slow
the task down waiting on the tty to redraw.

We now delay the progress meter 0.5 seconds (or 1 second if the
Python time.time() function isn't accurate enough) to avoid any
really fast tasks, like a no-op local sync.

Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce 2009-04-18 10:09:16 -07:00
parent 6ed4e28346
commit 2810cbc778
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
progress.py
View File

@ -14,6 +14,7 @@
# limitations under the License. # limitations under the License.
import sys import sys
from time import time
from trace import IsTrace from trace import IsTrace
class Progress(object): class Progress(object):
@ -22,6 +23,8 @@ class Progress(object):
self._total = total self._total = total
self._done = 0 self._done = 0
self._lastp = -1 self._lastp = -1
self._start = time()
self._show = False
def update(self, inc=1): def update(self, inc=1):
self._done += inc self._done += inc
@ -29,6 +32,12 @@ class Progress(object):
if IsTrace(): if IsTrace():
return return
if not self._show:
if 0.5 <= time() - self._start:
self._show = True
else:
return
if self._total <= 0: if self._total <= 0:
sys.stderr.write('\r%s: %d, ' % ( sys.stderr.write('\r%s: %d, ' % (
self._title, self._title,
@ -47,7 +56,7 @@ class Progress(object):
sys.stderr.flush() sys.stderr.flush()
def end(self): def end(self):
if IsTrace(): if IsTrace() or not self._show:
return return
if self._total <= 0: if self._total <= 0: