android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2024-12-21 07:16:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add reviewers automatically from project's git config

Browse Source 
The `review.URL.autocopy` setting sends email notification to the
named reviewers, but does not add them as reviewer on the uploaded
change.

Add a new setting `review.URL.autoreviewer`.  The named reviewers
will be added as reviewer on the uploaded change.

Change-Id: I3fddfb49edf346f8724fe15b84be8c39d43e7e65
Signed-off-by: bijia <bijia@xiaomi.com>
This commit is contained in:
bijia 2013-11-28 09:19:22 +08:00 committed by David Pursehouse
parent 2fb6466f79
commit 093fdb6587
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
subcmds/upload.py
View File

@ -89,6 +89,11 @@ to "true" then repo will assume you always answer "y" at the prompt,
and will not prompt you further. If it is set to "false" then repo and will not prompt you further. If it is set to "false" then repo
will assume you always answer "n", and will abort. will assume you always answer "n", and will abort.
review.URL.autoreviewer:
To automatically append a user or mailing list to reviews, you can set
a per-project or global Git option to do so.
review.URL.autocopy: review.URL.autocopy:
To automatically copy a user or mailing list to all uploaded reviews, To automatically copy a user or mailing list to all uploaded reviews,
@ -293,14 +298,20 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
self._UploadAndReport(opt, todo, people) self._UploadAndReport(opt, todo, people)
def _AppendAutoCcList(self, branch, people): def _AppendAutoList(self, branch, people):
""" """
Appends the list of reviewers in the git project's config.
Appends the list of users in the CC list in the git project's config if a Appends the list of users in the CC list in the git project's config if a
non-empty reviewer list was found. non-empty reviewer list was found.
""" """
name = branch.name name = branch.name
project = branch.project project = branch.project
key = 'review.%s.autoreviewer' % project.GetBranch(name).remote.review
raw_list = project.config.GetString(key)
if not raw_list is None:
people[0].extend([entry.strip() for entry in raw_list.split(',')])
key = 'review.%s.autocopy' % project.GetBranch(name).remote.review key = 'review.%s.autocopy' % project.GetBranch(name).remote.review
raw_list = project.config.GetString(key) raw_list = project.config.GetString(key)
if not raw_list is None and len(people[0]) > 0: if not raw_list is None and len(people[0]) > 0:
@ -323,7 +334,7 @@ Gerrit Code Review: http://code.google.com/p/gerrit/
for branch in todo: for branch in todo:
try: try:
people = copy.deepcopy(original_people) people = copy.deepcopy(original_people)
self._AppendAutoCcList(branch, people) self._AppendAutoList(branch, people)
# Check if there are local changes that may have been forgotten # Check if there are local changes that may have been forgotten
if branch.project.HasChanges(): if branch.project.HasChanges():