android/git-repo
1
Fork 0
mirror of https://gerrit.googlesource.com/git-repo synced 2025-01-02 16:14:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Repo: improve error detection for new ssh connections

Browse Source 
this check can only detect errors that happen within 1 sec after launching
ssh. But this is typically enough to catch configuration issues like
'connection refused' or 'authentication failed'.

Change-Id: I00b6f62d4c2889b1faa6c820e49a198554c92795
This commit is contained in:
Timo Lotterbach 2016-07-15 16:48:42 +02:00
parent 39252ba028
commit 05dc46b0e3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
git_config.py
View File

@ -464,9 +464,13 @@ def _open_ssh(host, port=None):
% (host,port, str(e)), file=sys.stderr) % (host,port, str(e)), file=sys.stderr)
return False return False
time.sleep(1)
ssh_died = (p.poll() is not None)
if ssh_died:
return False
_master_processes.append(p) _master_processes.append(p)
_master_keys.add(key) _master_keys.add(key)
time.sleep(1)
return True return True
finally: finally:
_master_keys_lock.release() _master_keys_lock.release()