2015-10-06 22:23:19 +00:00
|
|
|
# Copyright (C) 2015 The Android Open Source Project
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
2019-07-27 01:14:55 +00:00
|
|
|
"""Unittests for the wrapper.py module."""
|
|
|
|
|
2023-08-22 01:26:51 +00:00
|
|
|
import io
|
2015-10-06 22:23:19 +00:00
|
|
|
import os
|
2020-02-11 07:10:28 +00:00
|
|
|
import re
|
launcher: add a requirements framework to declare version dependencies
Currently we don't have a way for the checked out repo version to
declare the version of tools it needs before we start running it.
For somethings, like git, it's not a big deal as it can handle all
the asserts itself. But for things like Python, it's impossible
to reliably check before executing.
We're in this state now:
- we've been allowing Python 3.4, so the launcher accepts it
- the repo codebase starts using Python 3.6 features
- launcher tries to import us but hits syntax errors
- user is left confused and assuming new repo is broken because
they're seeing syntax errors
This scenario is playing out with old launchers that still accept
Python 2, and will continue to play out as time goes on and we want
to require newer versions of Python 3.
Lets create a JSON file to declare all these system requirements.
That file format is extremely stable, so loading & parsing from
even ancient versions of Python shouldn't be a problem. Then the
launcher can read these settings and check the system state before
attempting to execute any code. If the tools are too old, it can
clearly diagnose & display information to the user as to the real
problem (and not emit tracebacks or syntax errors).
We have a couple of different tool version checks already (git,
python, ssh) and can harmonize them in a single place.
This also allows us to assert a reverse dependency if the need
ever comes up: force the user to upgrade their `repo` launcher
before we'll let them run us. Even though the launcher warns
whenever a newer release is available, some users seem to ignore
that, or they don't use repo that often (on the scale of years),
and their upgrade jump is so dramatic that they fall back into
the syntax error pit.
Hopefully by the end of the year we can assume enough people
have upgraded their launcher such that we can delete all of the
duplicate version checks in the codebase. But until then, we'll
keep them to maintain coverage.
Change-Id: I5c12bbffdfd0a8ce978f39aa7f4674026fe9f4f8
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/293003
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2021-01-08 03:14:25 +00:00
|
|
|
import sys
|
2020-02-29 07:56:32 +00:00
|
|
|
import tempfile
|
2015-10-06 22:23:19 +00:00
|
|
|
import unittest
|
2019-06-13 06:24:21 +00:00
|
|
|
from unittest import mock
|
2015-10-06 22:23:19 +00:00
|
|
|
|
2020-12-01 14:58:53 +00:00
|
|
|
import git_command
|
2021-01-05 04:29:45 +00:00
|
|
|
import main
|
2015-10-06 22:23:19 +00:00
|
|
|
import wrapper
|
|
|
|
|
2020-02-12 06:20:19 +00:00
|
|
|
|
2015-10-06 22:23:19 +00:00
|
|
|
def fixture(*paths):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Return a path relative to tests/fixtures."""
|
|
|
|
return os.path.join(os.path.dirname(__file__), "fixtures", *paths)
|
2015-10-06 22:23:19 +00:00
|
|
|
|
2020-02-12 06:20:19 +00:00
|
|
|
|
2020-02-11 07:10:28 +00:00
|
|
|
class RepoWrapperTestCase(unittest.TestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""TestCase for the wrapper module."""
|
2020-02-12 06:20:19 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def setUp(self):
|
|
|
|
"""Load the wrapper module every time."""
|
|
|
|
wrapper.Wrapper.cache_clear()
|
|
|
|
self.wrapper = wrapper.Wrapper()
|
2015-10-06 22:23:19 +00:00
|
|
|
|
2020-02-11 07:10:28 +00:00
|
|
|
|
|
|
|
class RepoWrapperUnitTest(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Tests helper functions in the repo wrapper"""
|
|
|
|
|
|
|
|
def test_version(self):
|
|
|
|
"""Make sure _Version works."""
|
|
|
|
with self.assertRaises(SystemExit) as e:
|
2023-08-22 01:26:51 +00:00
|
|
|
with mock.patch("sys.stdout", new_callable=io.StringIO) as stdout:
|
|
|
|
with mock.patch(
|
|
|
|
"sys.stderr", new_callable=io.StringIO
|
|
|
|
) as stderr:
|
2023-03-11 06:46:20 +00:00
|
|
|
self.wrapper._Version()
|
|
|
|
self.assertEqual(0, e.exception.code)
|
|
|
|
self.assertEqual("", stderr.getvalue())
|
|
|
|
self.assertIn("repo launcher version", stdout.getvalue())
|
|
|
|
|
|
|
|
def test_python_constraints(self):
|
|
|
|
"""The launcher should never require newer than main.py."""
|
|
|
|
self.assertGreaterEqual(
|
|
|
|
main.MIN_PYTHON_VERSION_HARD, self.wrapper.MIN_PYTHON_VERSION_HARD
|
|
|
|
)
|
|
|
|
self.assertGreaterEqual(
|
|
|
|
main.MIN_PYTHON_VERSION_SOFT, self.wrapper.MIN_PYTHON_VERSION_SOFT
|
|
|
|
)
|
|
|
|
# Make sure the versions are themselves in sync.
|
|
|
|
self.assertGreaterEqual(
|
|
|
|
self.wrapper.MIN_PYTHON_VERSION_SOFT,
|
|
|
|
self.wrapper.MIN_PYTHON_VERSION_HARD,
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_init_parser(self):
|
|
|
|
"""Make sure 'init' GetParser works."""
|
2024-12-03 21:29:01 +00:00
|
|
|
parser = self.wrapper.GetParser()
|
2023-03-11 06:46:20 +00:00
|
|
|
opts, args = parser.parse_args([])
|
|
|
|
self.assertEqual([], args)
|
|
|
|
self.assertIsNone(opts.manifest_url)
|
|
|
|
|
2020-02-12 06:20:19 +00:00
|
|
|
|
2020-02-11 07:10:28 +00:00
|
|
|
class SetGitTrace2ParentSid(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check SetGitTrace2ParentSid behavior."""
|
|
|
|
|
|
|
|
KEY = "GIT_TRACE2_PARENT_SID"
|
|
|
|
VALID_FORMAT = re.compile(r"^repo-[0-9]{8}T[0-9]{6}Z-P[0-9a-f]{8}$")
|
|
|
|
|
|
|
|
def test_first_set(self):
|
|
|
|
"""Test env var not yet set."""
|
|
|
|
env = {}
|
|
|
|
self.wrapper.SetGitTrace2ParentSid(env)
|
|
|
|
self.assertIn(self.KEY, env)
|
|
|
|
value = env[self.KEY]
|
|
|
|
self.assertRegex(value, self.VALID_FORMAT)
|
|
|
|
|
|
|
|
def test_append(self):
|
|
|
|
"""Test env var is appended."""
|
|
|
|
env = {self.KEY: "pfx"}
|
|
|
|
self.wrapper.SetGitTrace2ParentSid(env)
|
|
|
|
self.assertIn(self.KEY, env)
|
|
|
|
value = env[self.KEY]
|
|
|
|
self.assertTrue(value.startswith("pfx/"))
|
|
|
|
self.assertRegex(value[4:], self.VALID_FORMAT)
|
|
|
|
|
|
|
|
def test_global_context(self):
|
|
|
|
"""Check os.environ gets updated by default."""
|
|
|
|
os.environ.pop(self.KEY, None)
|
|
|
|
self.wrapper.SetGitTrace2ParentSid()
|
|
|
|
self.assertIn(self.KEY, os.environ)
|
|
|
|
value = os.environ[self.KEY]
|
|
|
|
self.assertRegex(value, self.VALID_FORMAT)
|
2020-02-11 07:10:28 +00:00
|
|
|
|
|
|
|
|
2020-03-23 20:49:11 +00:00
|
|
|
class RunCommand(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check run_command behavior."""
|
2020-03-23 20:49:11 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_capture(self):
|
|
|
|
"""Check capture_output handling."""
|
|
|
|
ret = self.wrapper.run_command(["echo", "hi"], capture_output=True)
|
|
|
|
# echo command appends OS specific linesep, but on Windows + Git Bash
|
|
|
|
# we get UNIX ending, so we allow both.
|
|
|
|
self.assertIn(ret.stdout, ["hi" + os.linesep, "hi\n"])
|
2020-03-23 20:49:11 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_check(self):
|
|
|
|
"""Check check handling."""
|
|
|
|
self.wrapper.run_command(["true"], check=False)
|
|
|
|
self.wrapper.run_command(["true"], check=True)
|
|
|
|
self.wrapper.run_command(["false"], check=False)
|
|
|
|
with self.assertRaises(self.wrapper.RunError):
|
|
|
|
self.wrapper.run_command(["false"], check=True)
|
2020-03-23 20:49:11 +00:00
|
|
|
|
|
|
|
|
|
|
|
class RunGit(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check run_git behavior."""
|
2020-03-23 20:49:11 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_capture(self):
|
|
|
|
"""Check capture_output handling."""
|
|
|
|
ret = self.wrapper.run_git("--version")
|
|
|
|
self.assertIn("git", ret.stdout)
|
2020-03-23 20:49:11 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_check(self):
|
|
|
|
"""Check check handling."""
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper.run_git("--version-asdfasdf")
|
|
|
|
self.wrapper.run_git("--version-asdfasdf", check=False)
|
2020-03-23 20:49:11 +00:00
|
|
|
|
|
|
|
|
|
|
|
class ParseGitVersion(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check ParseGitVersion behavior."""
|
|
|
|
|
|
|
|
def test_autoload(self):
|
|
|
|
"""Check we can load the version from the live git."""
|
|
|
|
ret = self.wrapper.ParseGitVersion()
|
|
|
|
self.assertIsNotNone(ret)
|
|
|
|
|
|
|
|
def test_bad_ver(self):
|
|
|
|
"""Check handling of bad git versions."""
|
|
|
|
ret = self.wrapper.ParseGitVersion(ver_str="asdf")
|
|
|
|
self.assertIsNone(ret)
|
|
|
|
|
|
|
|
def test_normal_ver(self):
|
|
|
|
"""Check handling of normal git versions."""
|
|
|
|
ret = self.wrapper.ParseGitVersion(ver_str="git version 2.25.1")
|
|
|
|
self.assertEqual(2, ret.major)
|
|
|
|
self.assertEqual(25, ret.minor)
|
|
|
|
self.assertEqual(1, ret.micro)
|
|
|
|
self.assertEqual("2.25.1", ret.full)
|
|
|
|
|
|
|
|
def test_extended_ver(self):
|
|
|
|
"""Check handling of extended distro git versions."""
|
|
|
|
ret = self.wrapper.ParseGitVersion(
|
|
|
|
ver_str="git version 1.30.50.696.g5e7596f4ac-goog"
|
|
|
|
)
|
|
|
|
self.assertEqual(1, ret.major)
|
|
|
|
self.assertEqual(30, ret.minor)
|
|
|
|
self.assertEqual(50, ret.micro)
|
|
|
|
self.assertEqual("1.30.50.696.g5e7596f4ac-goog", ret.full)
|
2020-03-23 20:49:11 +00:00
|
|
|
|
|
|
|
|
|
|
|
class CheckGitVersion(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check _CheckGitVersion behavior."""
|
|
|
|
|
|
|
|
def test_unknown(self):
|
|
|
|
"""Unknown versions should abort."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "ParseGitVersion", return_value=None
|
|
|
|
):
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper._CheckGitVersion()
|
|
|
|
|
|
|
|
def test_old(self):
|
|
|
|
"""Old versions should abort."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper,
|
|
|
|
"ParseGitVersion",
|
|
|
|
return_value=self.wrapper.GitVersion(1, 0, 0, "1.0.0"),
|
|
|
|
):
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper._CheckGitVersion()
|
|
|
|
|
|
|
|
def test_new(self):
|
|
|
|
"""Newer versions should run fine."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper,
|
|
|
|
"ParseGitVersion",
|
|
|
|
return_value=self.wrapper.GitVersion(100, 0, 0, "100.0.0"),
|
|
|
|
):
|
|
|
|
self.wrapper._CheckGitVersion()
|
2020-03-23 20:49:11 +00:00
|
|
|
|
|
|
|
|
launcher: add a requirements framework to declare version dependencies
Currently we don't have a way for the checked out repo version to
declare the version of tools it needs before we start running it.
For somethings, like git, it's not a big deal as it can handle all
the asserts itself. But for things like Python, it's impossible
to reliably check before executing.
We're in this state now:
- we've been allowing Python 3.4, so the launcher accepts it
- the repo codebase starts using Python 3.6 features
- launcher tries to import us but hits syntax errors
- user is left confused and assuming new repo is broken because
they're seeing syntax errors
This scenario is playing out with old launchers that still accept
Python 2, and will continue to play out as time goes on and we want
to require newer versions of Python 3.
Lets create a JSON file to declare all these system requirements.
That file format is extremely stable, so loading & parsing from
even ancient versions of Python shouldn't be a problem. Then the
launcher can read these settings and check the system state before
attempting to execute any code. If the tools are too old, it can
clearly diagnose & display information to the user as to the real
problem (and not emit tracebacks or syntax errors).
We have a couple of different tool version checks already (git,
python, ssh) and can harmonize them in a single place.
This also allows us to assert a reverse dependency if the need
ever comes up: force the user to upgrade their `repo` launcher
before we'll let them run us. Even though the launcher warns
whenever a newer release is available, some users seem to ignore
that, or they don't use repo that often (on the scale of years),
and their upgrade jump is so dramatic that they fall back into
the syntax error pit.
Hopefully by the end of the year we can assume enough people
have upgraded their launcher such that we can delete all of the
duplicate version checks in the codebase. But until then, we'll
keep them to maintain coverage.
Change-Id: I5c12bbffdfd0a8ce978f39aa7f4674026fe9f4f8
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/293003
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2021-01-08 03:14:25 +00:00
|
|
|
class Requirements(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check Requirements handling."""
|
|
|
|
|
|
|
|
def test_missing_file(self):
|
|
|
|
"""Don't crash if the file is missing (old version)."""
|
|
|
|
testdir = os.path.dirname(os.path.realpath(__file__))
|
|
|
|
self.assertIsNone(self.wrapper.Requirements.from_dir(testdir))
|
|
|
|
self.assertIsNone(
|
|
|
|
self.wrapper.Requirements.from_file(
|
|
|
|
os.path.join(testdir, "xxxxxxxxxxxxxxxxxxxxxxxx")
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_corrupt_data(self):
|
|
|
|
"""If the file can't be parsed, don't blow up."""
|
|
|
|
self.assertIsNone(self.wrapper.Requirements.from_file(__file__))
|
|
|
|
self.assertIsNone(self.wrapper.Requirements.from_data(b"x"))
|
|
|
|
|
|
|
|
def test_valid_data(self):
|
|
|
|
"""Make sure we can parse the file we ship."""
|
|
|
|
self.assertIsNotNone(self.wrapper.Requirements.from_data(b"{}"))
|
|
|
|
rootdir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
|
|
|
|
self.assertIsNotNone(self.wrapper.Requirements.from_dir(rootdir))
|
|
|
|
self.assertIsNotNone(
|
|
|
|
self.wrapper.Requirements.from_file(
|
|
|
|
os.path.join(rootdir, "requirements.json")
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
def test_format_ver(self):
|
|
|
|
"""Check format_ver can format."""
|
|
|
|
self.assertEqual(
|
|
|
|
"1.2.3", self.wrapper.Requirements._format_ver((1, 2, 3))
|
|
|
|
)
|
|
|
|
self.assertEqual("1", self.wrapper.Requirements._format_ver([1]))
|
|
|
|
|
|
|
|
def test_assert_all_unknown(self):
|
|
|
|
"""Check assert_all works with incompatible file."""
|
|
|
|
reqs = self.wrapper.Requirements({})
|
|
|
|
reqs.assert_all()
|
|
|
|
|
|
|
|
def test_assert_all_new_repo(self):
|
|
|
|
"""Check assert_all accepts new enough repo."""
|
|
|
|
reqs = self.wrapper.Requirements({"repo": {"hard": [1, 0]}})
|
|
|
|
reqs.assert_all()
|
|
|
|
|
|
|
|
def test_assert_all_old_repo(self):
|
|
|
|
"""Check assert_all rejects old repo."""
|
|
|
|
reqs = self.wrapper.Requirements({"repo": {"hard": [99999, 0]}})
|
|
|
|
with self.assertRaises(SystemExit):
|
|
|
|
reqs.assert_all()
|
|
|
|
|
|
|
|
def test_assert_all_new_python(self):
|
|
|
|
"""Check assert_all accepts new enough python."""
|
|
|
|
reqs = self.wrapper.Requirements({"python": {"hard": sys.version_info}})
|
|
|
|
reqs.assert_all()
|
|
|
|
|
|
|
|
def test_assert_all_old_python(self):
|
|
|
|
"""Check assert_all rejects old python."""
|
|
|
|
reqs = self.wrapper.Requirements({"python": {"hard": [99999, 0]}})
|
|
|
|
with self.assertRaises(SystemExit):
|
|
|
|
reqs.assert_all()
|
|
|
|
|
|
|
|
def test_assert_ver_unknown(self):
|
|
|
|
"""Check assert_ver works with incompatible file."""
|
|
|
|
reqs = self.wrapper.Requirements({})
|
|
|
|
reqs.assert_ver("xxx", (1, 0))
|
|
|
|
|
|
|
|
def test_assert_ver_new(self):
|
|
|
|
"""Check assert_ver allows new enough versions."""
|
|
|
|
reqs = self.wrapper.Requirements(
|
|
|
|
{"git": {"hard": [1, 0], "soft": [2, 0]}}
|
|
|
|
)
|
|
|
|
reqs.assert_ver("git", (1, 0))
|
|
|
|
reqs.assert_ver("git", (1, 5))
|
|
|
|
reqs.assert_ver("git", (2, 0))
|
|
|
|
reqs.assert_ver("git", (2, 5))
|
|
|
|
|
|
|
|
def test_assert_ver_old(self):
|
|
|
|
"""Check assert_ver rejects old versions."""
|
|
|
|
reqs = self.wrapper.Requirements(
|
|
|
|
{"git": {"hard": [1, 0], "soft": [2, 0]}}
|
|
|
|
)
|
|
|
|
with self.assertRaises(SystemExit):
|
|
|
|
reqs.assert_ver("git", (0, 5))
|
launcher: add a requirements framework to declare version dependencies
Currently we don't have a way for the checked out repo version to
declare the version of tools it needs before we start running it.
For somethings, like git, it's not a big deal as it can handle all
the asserts itself. But for things like Python, it's impossible
to reliably check before executing.
We're in this state now:
- we've been allowing Python 3.4, so the launcher accepts it
- the repo codebase starts using Python 3.6 features
- launcher tries to import us but hits syntax errors
- user is left confused and assuming new repo is broken because
they're seeing syntax errors
This scenario is playing out with old launchers that still accept
Python 2, and will continue to play out as time goes on and we want
to require newer versions of Python 3.
Lets create a JSON file to declare all these system requirements.
That file format is extremely stable, so loading & parsing from
even ancient versions of Python shouldn't be a problem. Then the
launcher can read these settings and check the system state before
attempting to execute any code. If the tools are too old, it can
clearly diagnose & display information to the user as to the real
problem (and not emit tracebacks or syntax errors).
We have a couple of different tool version checks already (git,
python, ssh) and can harmonize them in a single place.
This also allows us to assert a reverse dependency if the need
ever comes up: force the user to upgrade their `repo` launcher
before we'll let them run us. Even though the launcher warns
whenever a newer release is available, some users seem to ignore
that, or they don't use repo that often (on the scale of years),
and their upgrade jump is so dramatic that they fall back into
the syntax error pit.
Hopefully by the end of the year we can assume enough people
have upgraded their launcher such that we can delete all of the
duplicate version checks in the codebase. But until then, we'll
keep them to maintain coverage.
Change-Id: I5c12bbffdfd0a8ce978f39aa7f4674026fe9f4f8
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/293003
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2021-01-08 03:14:25 +00:00
|
|
|
|
|
|
|
|
2020-02-29 07:53:41 +00:00
|
|
|
class NeedSetupGnuPG(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check NeedSetupGnuPG behavior."""
|
|
|
|
|
|
|
|
def test_missing_dir(self):
|
|
|
|
"""The ~/.repoconfig tree doesn't exist yet."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = os.path.join(tempdir, "foo")
|
|
|
|
self.assertTrue(self.wrapper.NeedSetupGnuPG())
|
|
|
|
|
|
|
|
def test_missing_keyring(self):
|
|
|
|
"""The keyring-version file doesn't exist yet."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = tempdir
|
|
|
|
self.assertTrue(self.wrapper.NeedSetupGnuPG())
|
|
|
|
|
|
|
|
def test_empty_keyring(self):
|
|
|
|
"""The keyring-version file exists, but is empty."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = tempdir
|
|
|
|
with open(os.path.join(tempdir, "keyring-version"), "w"):
|
|
|
|
pass
|
|
|
|
self.assertTrue(self.wrapper.NeedSetupGnuPG())
|
|
|
|
|
|
|
|
def test_old_keyring(self):
|
|
|
|
"""The keyring-version file exists, but it's old."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = tempdir
|
|
|
|
with open(os.path.join(tempdir, "keyring-version"), "w") as fp:
|
|
|
|
fp.write("1.0\n")
|
|
|
|
self.assertTrue(self.wrapper.NeedSetupGnuPG())
|
|
|
|
|
|
|
|
def test_new_keyring(self):
|
|
|
|
"""The keyring-version file exists, and is up-to-date."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = tempdir
|
|
|
|
with open(os.path.join(tempdir, "keyring-version"), "w") as fp:
|
|
|
|
fp.write("1000.0\n")
|
|
|
|
self.assertFalse(self.wrapper.NeedSetupGnuPG())
|
2020-02-29 07:53:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
class SetupGnuPG(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check SetupGnuPG behavior."""
|
|
|
|
|
|
|
|
def test_full(self):
|
|
|
|
"""Make sure it works completely."""
|
|
|
|
with tempfile.TemporaryDirectory(prefix="repo-tests") as tempdir:
|
|
|
|
self.wrapper.home_dot_repo = tempdir
|
|
|
|
self.wrapper.gpg_dir = os.path.join(
|
|
|
|
self.wrapper.home_dot_repo, "gnupg"
|
|
|
|
)
|
|
|
|
self.assertTrue(self.wrapper.SetupGnuPG(True))
|
2023-10-20 17:47:02 +00:00
|
|
|
with open(os.path.join(tempdir, "keyring-version")) as fp:
|
2023-03-11 06:46:20 +00:00
|
|
|
data = fp.read()
|
|
|
|
self.assertEqual(
|
|
|
|
".".join(str(x) for x in self.wrapper.KEYRING_VERSION),
|
|
|
|
data.strip(),
|
|
|
|
)
|
2020-02-29 07:53:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
class VerifyRev(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check verify_rev behavior."""
|
|
|
|
|
|
|
|
def test_verify_passes(self):
|
|
|
|
"""Check when we have a valid signed tag."""
|
|
|
|
desc_result = self.wrapper.RunResult(0, "v1.0\n", "")
|
|
|
|
gpg_result = self.wrapper.RunResult(0, "", "")
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "run_git", side_effect=(desc_result, gpg_result)
|
|
|
|
):
|
|
|
|
ret = self.wrapper.verify_rev(
|
|
|
|
"/", "refs/heads/stable", "1234", True
|
|
|
|
)
|
|
|
|
self.assertEqual("v1.0^0", ret)
|
|
|
|
|
|
|
|
def test_unsigned_commit(self):
|
|
|
|
"""Check we fall back to signed tag when we have an unsigned commit."""
|
|
|
|
desc_result = self.wrapper.RunResult(0, "v1.0-10-g1234\n", "")
|
|
|
|
gpg_result = self.wrapper.RunResult(0, "", "")
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "run_git", side_effect=(desc_result, gpg_result)
|
|
|
|
):
|
|
|
|
ret = self.wrapper.verify_rev(
|
|
|
|
"/", "refs/heads/stable", "1234", True
|
|
|
|
)
|
|
|
|
self.assertEqual("v1.0^0", ret)
|
|
|
|
|
|
|
|
def test_verify_fails(self):
|
|
|
|
"""Check we fall back to signed tag when we have an unsigned commit."""
|
|
|
|
desc_result = self.wrapper.RunResult(0, "v1.0-10-g1234\n", "")
|
|
|
|
gpg_result = Exception
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "run_git", side_effect=(desc_result, gpg_result)
|
|
|
|
):
|
|
|
|
with self.assertRaises(Exception):
|
|
|
|
self.wrapper.verify_rev("/", "refs/heads/stable", "1234", True)
|
2020-02-29 07:53:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
class GitCheckoutTestCase(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Tests that use a real/small git checkout."""
|
|
|
|
|
|
|
|
GIT_DIR = None
|
|
|
|
REV_LIST = None
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
def setUpClass(cls):
|
|
|
|
# Create a repo to operate on, but do it once per-class.
|
|
|
|
cls.tempdirobj = tempfile.TemporaryDirectory(prefix="repo-rev-tests")
|
|
|
|
cls.GIT_DIR = cls.tempdirobj.name
|
|
|
|
run_git = wrapper.Wrapper().run_git
|
|
|
|
|
|
|
|
remote = os.path.join(cls.GIT_DIR, "remote")
|
|
|
|
os.mkdir(remote)
|
|
|
|
|
|
|
|
# Tests need to assume, that main is default branch at init,
|
|
|
|
# which is not supported in config until 2.28.
|
|
|
|
if git_command.git_require((2, 28, 0)):
|
|
|
|
initstr = "--initial-branch=main"
|
|
|
|
else:
|
|
|
|
# Use template dir for init.
|
|
|
|
templatedir = tempfile.mkdtemp(prefix=".test-template")
|
|
|
|
with open(os.path.join(templatedir, "HEAD"), "w") as fp:
|
|
|
|
fp.write("ref: refs/heads/main\n")
|
|
|
|
initstr = "--template=" + templatedir
|
|
|
|
|
|
|
|
run_git("init", initstr, cwd=remote)
|
|
|
|
run_git("commit", "--allow-empty", "-minit", cwd=remote)
|
|
|
|
run_git("branch", "stable", cwd=remote)
|
|
|
|
run_git("tag", "v1.0", cwd=remote)
|
|
|
|
run_git("commit", "--allow-empty", "-m2nd commit", cwd=remote)
|
|
|
|
cls.REV_LIST = run_git(
|
|
|
|
"rev-list", "HEAD", cwd=remote
|
|
|
|
).stdout.splitlines()
|
|
|
|
|
|
|
|
run_git("init", cwd=cls.GIT_DIR)
|
|
|
|
run_git(
|
|
|
|
"fetch",
|
|
|
|
remote,
|
|
|
|
"+refs/heads/*:refs/remotes/origin/*",
|
|
|
|
cwd=cls.GIT_DIR,
|
|
|
|
)
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
def tearDownClass(cls):
|
|
|
|
if not cls.tempdirobj:
|
|
|
|
return
|
|
|
|
|
|
|
|
cls.tempdirobj.cleanup()
|
2020-02-29 07:56:32 +00:00
|
|
|
|
2020-02-29 07:53:41 +00:00
|
|
|
|
|
|
|
class ResolveRepoRev(GitCheckoutTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check resolve_repo_rev behavior."""
|
|
|
|
|
|
|
|
def test_explicit_branch(self):
|
|
|
|
"""Check refs/heads/branch argument."""
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(
|
|
|
|
self.GIT_DIR, "refs/heads/stable"
|
|
|
|
)
|
|
|
|
self.assertEqual("refs/heads/stable", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[1], lrev)
|
|
|
|
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper.resolve_repo_rev(self.GIT_DIR, "refs/heads/unknown")
|
|
|
|
|
|
|
|
def test_explicit_tag(self):
|
|
|
|
"""Check refs/tags/tag argument."""
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(
|
|
|
|
self.GIT_DIR, "refs/tags/v1.0"
|
|
|
|
)
|
|
|
|
self.assertEqual("refs/tags/v1.0", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[1], lrev)
|
|
|
|
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper.resolve_repo_rev(self.GIT_DIR, "refs/tags/unknown")
|
|
|
|
|
|
|
|
def test_branch_name(self):
|
|
|
|
"""Check branch argument."""
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(self.GIT_DIR, "stable")
|
|
|
|
self.assertEqual("refs/heads/stable", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[1], lrev)
|
|
|
|
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(self.GIT_DIR, "main")
|
|
|
|
self.assertEqual("refs/heads/main", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[0], lrev)
|
|
|
|
|
|
|
|
def test_tag_name(self):
|
|
|
|
"""Check tag argument."""
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(self.GIT_DIR, "v1.0")
|
|
|
|
self.assertEqual("refs/tags/v1.0", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[1], lrev)
|
|
|
|
|
|
|
|
def test_full_commit(self):
|
|
|
|
"""Check specific commit argument."""
|
|
|
|
commit = self.REV_LIST[0]
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(self.GIT_DIR, commit)
|
|
|
|
self.assertEqual(commit, rrev)
|
|
|
|
self.assertEqual(commit, lrev)
|
|
|
|
|
|
|
|
def test_partial_commit(self):
|
|
|
|
"""Check specific (partial) commit argument."""
|
|
|
|
commit = self.REV_LIST[0][0:20]
|
|
|
|
rrev, lrev = self.wrapper.resolve_repo_rev(self.GIT_DIR, commit)
|
|
|
|
self.assertEqual(self.REV_LIST[0], rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[0], lrev)
|
|
|
|
|
|
|
|
def test_unknown(self):
|
|
|
|
"""Check unknown ref/commit argument."""
|
|
|
|
with self.assertRaises(self.wrapper.CloneFailure):
|
|
|
|
self.wrapper.resolve_repo_rev(self.GIT_DIR, "boooooooya")
|
2020-02-29 07:56:32 +00:00
|
|
|
|
|
|
|
|
2020-02-29 07:53:41 +00:00
|
|
|
class CheckRepoVerify(RepoWrapperTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check check_repo_verify behavior."""
|
2020-02-29 07:53:41 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_no_verify(self):
|
|
|
|
"""Always fail with --no-repo-verify."""
|
|
|
|
self.assertFalse(self.wrapper.check_repo_verify(False))
|
2020-02-29 07:53:41 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_gpg_initialized(self):
|
|
|
|
"""Should pass if gpg is setup already."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "NeedSetupGnuPG", return_value=False
|
|
|
|
):
|
|
|
|
self.assertTrue(self.wrapper.check_repo_verify(True))
|
2020-02-29 07:53:41 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
def test_need_gpg_setup(self):
|
|
|
|
"""Should pass/fail based on gpg setup."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "NeedSetupGnuPG", return_value=True
|
|
|
|
):
|
|
|
|
with mock.patch.object(self.wrapper, "SetupGnuPG") as m:
|
|
|
|
m.return_value = True
|
|
|
|
self.assertTrue(self.wrapper.check_repo_verify(True))
|
2020-02-29 07:53:41 +00:00
|
|
|
|
2023-03-11 06:46:20 +00:00
|
|
|
m.return_value = False
|
|
|
|
self.assertFalse(self.wrapper.check_repo_verify(True))
|
2020-02-29 07:53:41 +00:00
|
|
|
|
|
|
|
|
|
|
|
class CheckRepoRev(GitCheckoutTestCase):
|
2023-03-11 06:46:20 +00:00
|
|
|
"""Check check_repo_rev behavior."""
|
|
|
|
|
|
|
|
def test_verify_works(self):
|
|
|
|
"""Should pass when verification passes."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "check_repo_verify", return_value=True
|
|
|
|
):
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "verify_rev", return_value="12345"
|
|
|
|
):
|
|
|
|
rrev, lrev = self.wrapper.check_repo_rev(self.GIT_DIR, "stable")
|
|
|
|
self.assertEqual("refs/heads/stable", rrev)
|
|
|
|
self.assertEqual("12345", lrev)
|
|
|
|
|
|
|
|
def test_verify_fails(self):
|
|
|
|
"""Should fail when verification fails."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "check_repo_verify", return_value=True
|
|
|
|
):
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "verify_rev", side_effect=Exception
|
|
|
|
):
|
|
|
|
with self.assertRaises(Exception):
|
|
|
|
self.wrapper.check_repo_rev(self.GIT_DIR, "stable")
|
|
|
|
|
|
|
|
def test_verify_ignore(self):
|
|
|
|
"""Should pass when verification is disabled."""
|
|
|
|
with mock.patch.object(
|
|
|
|
self.wrapper, "verify_rev", side_effect=Exception
|
|
|
|
):
|
|
|
|
rrev, lrev = self.wrapper.check_repo_rev(
|
|
|
|
self.GIT_DIR, "stable", repo_verify=False
|
|
|
|
)
|
|
|
|
self.assertEqual("refs/heads/stable", rrev)
|
|
|
|
self.assertEqual(self.REV_LIST[1], lrev)
|